Skip to content

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Feb 27, 2025

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 27, 2025
@saschagrunert saschagrunert changed the title [KEP-4639] Graduate image volume source to beta WIP: [KEP-4639] Graduate image volume source to beta Feb 27, 2025
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 27, 2025
@netlify
Copy link

netlify bot commented Feb 27, 2025

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit eab6813
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/67d29e10599f4c0009d36e50

@netlify
Copy link

netlify bot commented Feb 27, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit eab6813
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67d29e10e76e4e00081ceb58
😎 Deploy Preview https://deploy-preview-49936--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@saschagrunert saschagrunert force-pushed the dev-1.33-image-volume-beta branch from 67d69da to f465cb2 Compare March 10, 2025 09:14
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 10, 2025
@saschagrunert saschagrunert force-pushed the dev-1.33-image-volume-beta branch from f465cb2 to cbbe0ad Compare March 10, 2025 09:22
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2025
@saschagrunert saschagrunert changed the title WIP: [KEP-4639] Graduate image volume source to beta [KEP-4639] Graduate image volume source to beta Mar 10, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 10, 2025
@saschagrunert
Copy link
Member Author

saschagrunert commented Mar 10, 2025

Ready for review. PTAL @kubernetes/sig-node-pr-reviews

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. kind/feature Categorizes issue or PR as related to a new feature. labels Mar 10, 2025
@github-project-automation github-project-automation bot moved this from Triage to Waiting on Author in SIG Node: code and documentation PRs Mar 12, 2025
@Shubham82
Copy link
Contributor

/hold

(unhold this PR when corresponding upstream PRs kubernetes/kubernetes#130135, kubernetes/kubernetes#130681 merges)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2025
@saschagrunert saschagrunert force-pushed the dev-1.33-image-volume-beta branch from cbbe0ad to 76ba7b2 Compare March 12, 2025 12:58
@saschagrunert
Copy link
Member Author

/hold

(unhold this PR when corresponding upstream PRs kubernetes/kubernetes#130135, kubernetes/kubernetes#130681 merges)

kubernetes/kubernetes#130135 and kubernetes/kubernetes#130681 is more an optional thing because we need runtime support.

@saschagrunert saschagrunert force-pushed the dev-1.33-image-volume-beta branch from 76ba7b2 to 900e860 Compare March 13, 2025 08:57
Update the documentation to reflect the graduated feature.

Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert saschagrunert force-pushed the dev-1.33-image-volume-beta branch from 900e860 to eab6813 Compare March 13, 2025 08:57
@saschagrunert
Copy link
Member Author

@kubernetes/sig-node-pr-reviews PTAL

@saschagrunert
Copy link
Member Author

PTAL @kubernetes/sig-node-pr-reviews

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2025
@tengqm
Copy link
Contributor

tengqm commented Mar 26, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2025
@Shubham82
Copy link
Contributor

@saschagrunert, thanks for the PR. The changes look good to me, need a review from sig-node.

@haircommander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2b7d27eab7b668400883332fca31aca9dbbf0656

@k8s-ci-robot k8s-ci-robot merged commit 726d06f into kubernetes:dev-1.33 Apr 3, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in SIG Node: code and documentation PRs Apr 3, 2025
@saschagrunert saschagrunert deleted the dev-1.33-image-volume-beta branch April 3, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

5 participants